Modify transformationPlugins contract to return Object to support One to Many transformations #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
peternied and
sumobrian
as code owners
… to Many transformations Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
force-pushed
the
TransformationPluginObjectContract
branch
from
86a29fa to
4452d8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
============================================
- Coverage 80.64% 80.55% -0.09%
+ Complexity 3076 3075 -1
============================================
Files 421 421
Lines 15610 15629 +19
Branches 1053 1057 +4
============================================
+ Hits 12588 12590 +2
- Misses 2381 2394 +13
- Partials 641 645 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peternied
approved these changes
Dec 19, 2024
| return MAPPER.writeValueAsString(map); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private MigrationItem transformMigrationItem(MigrationItem migrationItem) { | ||
| // Keep untouched original for logging | ||
| final Map<String, Object> originalMap = MAPPER.convertValue(migrationItem, Map.class); | ||
| var transformedMigrationItem = transformer.transformJson(MAPPER.convertValue(migrationItem, Map.class)); | ||
| Object transformedMigrationItem = transformer.transformJson(MAPPER.convertValue(migrationItem, Map.class)); |
There was a problem hiding this comment.
Could you switch back to var?
Suggested change
| Object transformedMigrationItem = transformer.transformJson(MAPPER.convertValue(migrationItem, Map.class)); | |
| var transformedMigrationItem = transformer.transformJson(MAPPER.convertValue(migrationItem, Map.class)); |
| @@ -142,7 +142,7 @@ public void accept(SourceTargetCaptureTuple tuple, ParsedHttpMessagesAsDicts par | |||
| if (tupleLogger.isInfoEnabled()) { | |||
| try { | |||
| var originalTuple = toJSONObject(tuple, parsedMessages); | |||
| var transformedTuple = tupleTransformer.transformJson(originalTuple); | |||
| Object transformedTuple = tupleTransformer.transformJson(originalTuple); | |||
There was a problem hiding this comment.
Suggested change
| Object transformedTuple = tupleTransformer.transformJson(originalTuple); | |
| var transformedTuple = tupleTransformer.transformJson(originalTuple); |
There was a problem hiding this comment.
Seems to be in a number of other places in this PR too. Seems like it might reduce the change surface area, your call.
| var headers = (Map<String, Object>) incomingJson.get(JsonKeysForHttpMessage.HEADERS_KEY); | ||
| public Object transformJson(Object incomingJson) { | ||
| @SuppressWarnings("unchecked") | ||
| var headers = (Map<String, Object>) ((Map<String, Object>) incomingJson).get(JsonKeysForHttpMessage.HEADERS_KEY); |
There was a problem hiding this comment.
Could we make a function that encapsulates (read as 'hides') the casting cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify transformationPlugins contract to return Object to support One to Many transformations.
Initial step in plugin framework, applications (RFS, Metadata, Replayer) still need to be updated to support
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.