Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MultiTypeMappingTransformationTest #1195

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Dec 11, 2024

Description

Enable MultiTypeMappingTransformationTest

Fixes issue in GHA by not depending on local mounts and instead copying the required files into the container.
Reverts docker caching recently added in gradle gha actions, will be addressed with MIGRATIONS-2265

  • Category: Test fix
  • Why these changes are required? Ensure full coverage of tests in GHA
  • What is the old behavior before changes and new behavior after changes? Test Disabled, now enabled

Issues Resolved

No jira created

Is this a backport? If so, please add backport PR # and/or commits #

Testing

GHA, verified working locally too

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait force-pushed the EnableMultiTypeGHA branch 3 times, most recently from 6e2af66 to 5fa0a93 Compare December 11, 2024 19:47
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (4e26c16) to head (e41394c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1195      +/-   ##
============================================
+ Coverage     80.61%   80.64%   +0.03%     
+ Complexity     3080     3075       -5     
============================================
  Files           421      421              
  Lines         15592    15609      +17     
  Branches       1053     1053              
============================================
+ Hits          12569    12588      +19     
+ Misses         2380     2378       -2     
  Partials        643      643              
Flag Coverage Δ
unittests 80.64% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait merged commit ac5dd29 into opensearch-project:main Dec 11, 2024
22 checks passed
@AndreKurait AndreKurait deleted the EnableMultiTypeGHA branch December 11, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants