Add robustness for missing TupleComponents #1194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While prepping for the demo today, we encountered a bug while checking the tuples. A tuple was throwing the following error (shown with a minimal-ish valid tuple):
This tuple is as-expected, except that it doesn't have a
sourceResponse
field, which is a valid state for a tuple. The correct behavior is to translate all the present components of the tuple, but not to worry about the missing ones.The fixed behavior (same tuple):
I add a log message at info level, so a user can add
-v
to view these logs (and others), but they don't indicate an error and shouldn't be surfaced to most users.Issues Resolved
Testing
Manual, working on a unit test.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.