Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For backfill bulk items, don't transcribe the documents through jinjava but just have it pulled from the source doc. #1191

Conversation

gregschohn
Copy link
Collaborator

For backfill bulk items, don't transcribe the documents through jinjava but just have it pulled from the source doc.

Description

  • Category Performance enhancement
  • Why these changes are required? To reduce wasted transcriptions and parses
  • What is the old behavior before changes and new behavior after changes? Should be no semantic differences.

Issues Resolved

No Jira

Is this a backport? If so, please add backport PR # and/or commits #

Testing

CICD tests

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…va but just have it pulled from the source doc.

Signed-off-by: Greg Schohn <[email protected]>
@gregschohn gregschohn marked this pull request as ready for review December 10, 2024 21:13
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (6d3b225) to head (15272f5).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1191   +/-   ##
=========================================
  Coverage     80.55%   80.55%           
+ Complexity     3074     3071    -3     
=========================================
  Files           421      421           
  Lines         15545    15545           
  Branches       1047     1047           
=========================================
  Hits          12522    12522           
+ Misses         2380     2378    -2     
- Partials        643      645    +2     
Flag Coverage Δ
unittests 80.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gregschohn gregschohn merged commit 4e26c16 into opensearch-project:main Dec 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants