Address a number of sonarqube java issues #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issues: - Remove this use of "put"; it is deprecated. - Remove this unnecessary cast to "Map". - Rename field "TYPE" to prevent any misunderstanding/clash with field "type" defined in superclass "org.opensearch.migrations.bulkload.models.MigrationItem". - Reorder the modifiers to comply with the Java Language Specification. - Change the visibility of this constructor to "protected". - Replace this lambda with method reference '*Template.class::isInstance'. - Replace this lambda with method reference '*Template.class::cast'. - Remove this unused method parameter "templateType". - Remove the parentheses around the "kvp" parameter Exclusions for false positives: - Set the credentials provider explicitly on this builder - Set the region explicitly on this builder Signed-off-by: Peter Nied <[email protected]>
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson and
sumobrian
as code owners
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
|
Moving to draft while attempting to root cause a memory leak - https://opensearch.atlassian.net/browse/MIGRATIONS-2250 |
Signed-off-by: Peter Nied <[email protected]>
This reverts commit 8ca94d5. Signed-off-by: Peter Nied <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
============================================
+ Coverage 80.61% 80.63% +0.02%
+ Complexity 3080 3075 -5
============================================
Files 421 421
Lines 15598 15609 +11
Branches 1053 1053
============================================
+ Hits 12575 12587 +12
+ Misses 2380 2379 -1
Partials 643 643
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lewijacn
approved these changes
Dec 11, 2024
DataGenerator/src/main/java/org/opensearch/migrations/data/workloads/HttpLogs.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues:
Exclusions for false positives:
Issues Resolved
Fix Java SonarQube issueshttps://opensearch.atlassian.net/browse/MIGRATIONS-2248Note; I've not worked on any issues that are part of the critical paths for transformations or sub-shard processing.
From
To
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.