Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGRATIONS-2243 - Replace 'Shards' verbiage with 'Fragment' in console backfill status #1179

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

sumobrian
Copy link
Collaborator

@sumobrian sumobrian commented Dec 5, 2024

Description

The customer-facing issue #1172 highlights confusion arising from the use of the term "shard" to describe both console backfill and console snapshot operations. The shard count in a snapshot does not necessarily match the shard count in a backfill. For instance, some indices (and their corresponding shards) may be excluded from the backill. To address this, we propose changing the terminology from "shards" to "worker items" for backfill operations. This change aligns with potential future updates where multiple worker items may be associated with a single shard.

  • Category: Maintenance
  • What is the old behavior before changes and new behavior after changes? console backfill status --deep-check displays items as "Work Items" instead of "Shards"

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-2243

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (3d82d1f) to head (43825de).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1179   +/-   ##
=========================================
  Coverage     80.97%   80.97%           
  Complexity     2996     2996           
=========================================
  Files           407      407           
  Lines         15241    15241           
  Branches       1021     1021           
=========================================
  Hits          12342    12342           
  Misses         2272     2272           
  Partials        627      627           
Flag Coverage Δ
unittests 80.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumobrian sumobrian marked this pull request as ready for review December 5, 2024 21:48
Copy link
Member

@AndreKurait AndreKurait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumobrian sumobrian merged commit d7681d2 into opensearch-project:main Dec 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants