Fix bug handle empty mappings when removing mapping types #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves opensearch-project#1177 Signed-off-by: Peter Nied <[email protected]>
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
============================================
- Coverage 81.01% 80.98% -0.04%
- Complexity 2996 2997 +1
============================================
Files 407 407
Lines 15234 15241 +7
Branches 1021 1021
============================================
+ Hits 12342 12343 +1
- Misses 2265 2271 +6
Partials 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Nied <[email protected]>
peternied
force-pushed
the
empty-mappings
branch
from
263574b to
04724ff
Compare
lewijacn
reviewed
Dec 4, 2024
| transformIndex(indexTemplate, IndexType.TEMPLATE); | ||
| templates.set(template.getKey(), indexTemplate.getRawJson()); | ||
| } catch (Exception e) { | ||
| log.atError() |
There was a problem hiding this comment.
Do we currently populate anything in the summary to say a transformation didn't work?
There was a problem hiding this comment.
Good callout - Nope, any items that are 'rejected' in this way will never show up in the UX (So at least there wouldn't be a false positive)
We will need to reorganize the data processing model to handle this cases :(
lewijacn
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug handle empty mappings when removing mapping types
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.