Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline sonarqube issue count #1169

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Nov 26, 2024

Description

Add baseline sonarqube issue count of 89 so that commits that don't make it worse pass. As we resolve issues, we can reduce this number to avoid regressions.

  • Category: Test fix
  • Why these changes are required? GHA should show as passing for commits that do not introduce issues
  • What is the old behavior before changes and new behavior after changes? All commits and PRs showed failing sonarqube

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

GHA

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (04d4d43) to head (e69b87a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1169   +/-   ##
=========================================
  Coverage     80.95%   80.95%           
  Complexity     2996     2996           
=========================================
  Files           407      407           
  Lines         15229    15229           
  Branches       1023     1023           
=========================================
  Hits          12328    12328           
  Misses         2272     2272           
  Partials        629      629           
Flag Coverage Δ
unittests 80.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait merged commit c24b88d into opensearch-project:main Nov 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants