Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer managedServiceSourceSnapshotEnabled when not set #1165

Merged

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Nov 26, 2024

Description

Infer managedServiceSourceSnapshotEnabled when not set, setting to true if sigv4 auth is set on the source.

  • Category: Enhancement
  • Why these changes are required? Customer encountered failure when set sigv4 source auth but did not set managedServiceSourceSnapshotEnabled
  • What is the old behavior before changes and new behavior after changes? managedServiceSourceSnapshotEnabled was required for managed service auth, now sigv4 can just be set.

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-2233

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Added unit testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (18e83bb) to head (57ec890).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1165   +/-   ##
=========================================
  Coverage     80.94%   80.95%           
- Complexity     2995     2996    +1     
=========================================
  Files           407      407           
  Lines         15229    15229           
  Branches       1023     1023           
=========================================
+ Hits          12327    12328    +1     
+ Misses         2273     2272    -1     
  Partials        629      629           
Flag Coverage Δ
unittests 80.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lewijacn lewijacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreKurait AndreKurait merged commit 04d4d43 into opensearch-project:main Nov 26, 2024
21 of 22 checks passed
@AndreKurait AndreKurait deleted the inferSnapshotRoleForSigv4 branch November 26, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants