Refactor online radix sorter #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Schohn <[email protected]>
…to coreUtilities. Followup to the last commit. Signed-off-by: Greg Schohn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
=======================================
Coverage ? 80.73%
Complexity ? 2951
=======================================
Files ? 400
Lines ? 15104
Branches ? 1021
=======================================
Hits ? 12194
Misses ? 2297
Partials ? 613
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
gregschohn
requested review from
AndreKurait,
chelma,
lewijacn,
mikaylathompson,
peternied and
sumobrian
as code owners
chelma
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the TrackedFuture classes and OnlineRadixSorter into coreUtilities.
The only change to logic was to move some Jackson formatting from a class into a single test & taking a test dependency on Jackson. We did have an implementation dependency on jackson, but that's been converted to just a testDependency. It wasn't needed to build and makes the cost of using coreUtilities much greater for others.
Issues Resolved
no issue, but related to 2128
Testing
gradle
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.