Sonarqube fixes from subshard work coordination #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikayla Thompson <[email protected]>
mikaylathompson
commented
Nov 19, 2024
| @@ -59,6 +59,8 @@ private void setupShardWorkItems( | |||
| Duration.ofMinutes(5), | |||
| context::createWorkAcquisitionContext | |||
| ); | |||
| } catch (InterruptedException e) { | |||
| throw e; | |||
There was a problem hiding this comment.
mikaylathompson
commented
Nov 19, 2024
| } catch (Exception e) { | ||
| attempt++; | ||
| if (attempt > maxRetries) { | ||
| exceptionConsumer.accept(e); | ||
| throw new RetriesExceededException(e, attempt); | ||
| } | ||
| Duration sleepDuration = Duration.ofMillis((long) (Math.pow(2.0, attempt - 1) * baseRetryTimeMs)); | ||
| Duration sleepDuration = Duration.ofMillis((long) (Math.pow(2.0, attempt - 1.0) * baseRetryTimeMs)); |
There was a problem hiding this comment.
mikaylathompson
commented
Nov 19, 2024
| @@ -161,13 +161,15 @@ private static void retryWithExponentialBackoff( | |||
| Exception underlyingException = (Exception) e.getCause(); | |||
| exceptionConsumer.accept(underlyingException); | |||
| throw new IllegalStateException(underlyingException); | |||
| } catch (InterruptedException e) { | |||
| throw e; | |||
There was a problem hiding this comment.
mikaylathompson
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
peternied and
sumobrian
as code owners
Signed-off-by: Mikayla Thompson <[email protected]>
gregschohn
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
============================================
- Coverage 80.75% 80.72% -0.04%
+ Complexity 2953 2952 -1
============================================
Files 399 399
Lines 15101 15106 +5
Branches 1021 1021
============================================
- Hits 12195 12194 -1
- Misses 2292 2298 +6
Partials 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
peternied
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sonarqube had a few complaints about details of the sub-shard work coordination implementation. Quick fixes in this PR.
Issues Resolved
n/a individual issues linked in comments
Testing
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.