Add VPCEndpoints on created VPC #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://opensearch.atlassian.net/browse/MIGRATIONS-2145 Signed-off-by: Peter Nied <[email protected]>
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson and
sumobrian
as code owners
peternied
commented
Nov 19, 2024
| vpc: vpc, | ||
| }); | ||
|
|
||
| const serviceEndpoints = [ |
There was a problem hiding this comment.
Only added endpoints with substantive amount of traffic. We had many more in the MA network-stack, but these are really the only ones that would see a price difference. Its a 1/3 the cost to use the VPCe compared to the NAT Gateway.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
=========================================
Coverage 80.72% 80.72%
Complexity 2953 2953
=========================================
Files 399 399
Lines 15106 15106
Branches 1021 1021
=========================================
Hits 12195 12195
Misses 2297 2297
Partials 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Peter Nied <[email protected]>
lewijacn
reviewed
Nov 19, 2024
deployment/cdk/opensearch-service-migration/lib/migration-assistance-stack.ts
Show resolved
Hide resolved
AndreKurait
approved these changes
Nov 19, 2024
Signed-off-by: Peter Nied <[email protected]>
peternied
changed the title
With the current latest AL2023 image al2023-ami-2023.6.20241111.0-kernel-6.1-x86_64 npm install hangs indefinately. We are switching back to an older version that works and providing a way to incrementially update to AMIs that we have tested. Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
This reverts commit c9f9cbb. Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
|
Just deployed and verified the latest version including the AMI locking changes. |
Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add VPCEndpoints for the created VPC flow
Issues Resolved
Testing
Deployed to AWS account and logged onto bootstrap box
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.