Split codecov upload to separate github actions workflow #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
=========================================
Coverage 80.72% 80.72%
Complexity 2947 2947
=========================================
Files 399 399
Lines 14965 14965
Branches 1017 1017
=========================================
Hits 12080 12080
Misses 2274 2274
Partials 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…heck run with pull_request trigger Signed-off-by: Andre Kurait <[email protected]>
peternied
reviewed
Nov 14, 2024
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
commented
Nov 14, 2024
| - python-e2e-tests | ||
| - python-lint | ||
| - python-tests | ||
| # Temp disable linting from blocking |
There was a problem hiding this comment.
Will revert this after merging this change
Signed-off-by: Andre Kurait <[email protected]>
peternied
approved these changes
Nov 14, 2024
|
@opensearch-project/admin Can you force merge this change, we accidentally broke our required CI checks and this will resolve that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split codecov upload to separate github actions workflow.
This enables making the CI workflow trigger on
pull_requestas it will not need secret access making modifications much easier.Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Lots of testing on my fork with push, pr, and pr from a fork.
E.g.: AndreKurait#7
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.