[CDK] Validate source endpoint and add default port if missing #1125
Conversation
…sing Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
requested review from
AndreKurait,
chelma,
gregschohn,
mikaylathompson,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
=========================================
Coverage 80.54% 80.54%
Complexity 2907 2907
=========================================
Files 393 393
Lines 14630 14630
Branches 1007 1007
=========================================
Hits 11784 11784
Misses 2233 2233
Partials 613 613
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| const deployId = props.addOnMigrationDeployId ? props.addOnMigrationDeployId : props.defaultDeployId; | ||
| createMigrationStringParameter(this, formattedClusterEndpoint, { | ||
| createMigrationStringParameter(this, props.targetClusterEndpoint, { |
There was a problem hiding this comment.
Why did this line change? From the rest of the PR, I can't figure that out.
There was a problem hiding this comment.
props.targetClusterEndpoint is already formatted from calling validateAndReturnFormattedHttpURL from parseClusterDefinition in stack-composer.
This now parsed/formatted endpoint that is in targetCluster.endpoint is passed as props.targetClusterEndpoint rendering formatting in this stack unnecessary.
Implementation LGTM
Description
Validate endpoints for source and target and add default ports if missing. This should result in a consistent pattern for our endpoints in CDK and prevent Capture Proxy errors from providing a destinationURI without a port.
Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-2035
Is this a backport? If so, please add backport PR # and/or commits #
Testing
CDK testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.