Use CFN input for VPC id and Stage #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
requested review from
AndreKurait,
chelma,
gregschohn,
mikaylathompson,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
============================================
+ Coverage 80.51% 80.54% +0.03%
- Complexity 2871 2907 +36
============================================
Files 393 393
Lines 14554 14630 +76
Branches 1000 1007 +7
============================================
+ Hits 11718 11784 +66
- Misses 2229 2233 +4
- Partials 607 613 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peternied
approved these changes
Nov 7, 2024
| @@ -188,6 +182,13 @@ export class SolutionsInfrastructureStack extends Stack { | |||
| vpc = importVPC(this, vpcIdParameter, availabilityZonesParameter, privateSubnetIdsParameter); | |||
| } | |||
|
|
|||
| const cfnInitConfig: InitElement[] = [ | |||
| InitCommand.shellCommand(`echo "export MIGRATIONS_APP_REGISTRY_ARN=${appRegistryAppARN}; export MIGRATIONS_USER_AGENT=${solutionsUserAgent}; export VPC_ID=${vpc.vpcId}; export STAGE=${stageParameter.valueAsString}" > /etc/profile.d/solutionsEnv.sh`), | |||
There was a problem hiding this comment.
Nit: create a function to generate these environment variables exports
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make this input available on the bootstrap instance, and fill in appropriate CDK context if available
Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-2205
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Manual deployments for both paths to CFN
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.