Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for RemoteReaderClient #1116

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Nov 5, 2024

Description

Add unit tests. Followup from https://github.com/opensearch-project/opensearch-migrations/pull/1114/files

  • Category: Test
  • Why these changes are required? Explicitly test new code paths
  • What is the old behavior before changes and new behavior after changes? No behavior change

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Unit test

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait marked this pull request as ready for review November 5, 2024 17:47
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (e78d172) to head (616ebed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1116      +/-   ##
============================================
+ Coverage     80.40%   80.46%   +0.05%     
- Complexity     2944     2947       +3     
============================================
  Files           393      393              
  Lines         14536    14536              
  Branches       1001     1001              
============================================
+ Hits          11688    11696       +8     
+ Misses         2242     2235       -7     
+ Partials        606      605       -1     
Flag Coverage Δ
gradle-test 78.53% <ø> (+0.06%) ⬆️
python-test 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@peternied peternied merged commit 2e28a97 into opensearch-project:main Nov 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants