Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include versions in maven publish #1081

Merged

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Oct 18, 2024

Description

With the change that added the commonDependencyConstraints package, we need to add propagating to the maven pom files to better enable dependency resolution during importing.

Before

  <dependencies>
    <dependency>
      <groupId>software.amazon.awssdk</groupId>
      <artifactId>arns</artifactId>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>software.amazon.awssdk</groupId>
      <artifactId>auth</artifactId>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>software.amazon.awssdk</groupId>
      <artifactId>sdk-core</artifactId>
      <scope>runtime</scope>
    </dependency>
    <dependency>

After

In the pom file:

  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.apache.commons</groupId>
        <artifactId>commons-text</artifactId>
        <version>1.10.0</version>
      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-api</artifactId>
      <version>2.0.13</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
  • Category: Bug Fix
  • Why these changes are required? Publish complete pom files to maven
  • What is the old behavior before changes and new behavior after changes? Pom files didn't include dependency versions

Issues Resolved

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Ran ./gradlew publish before and after and inspected build/repository artifacts

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (43913b1) to head (a4252a3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1081   +/-   ##
=========================================
  Coverage     80.66%   80.66%           
  Complexity     2893     2893           
=========================================
  Files           383      383           
  Lines         14361    14361           
  Branches        989      989           
=========================================
  Hits          11584    11584           
  Misses         2184     2184           
  Partials        593      593           
Flag Coverage Δ
gradle-test 78.75% <ø> (ø)
python-test 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait marked this pull request as ready for review October 18, 2024 19:05
Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this does what it does, but I can believe the results and believe that they're scoped to just the maven artifact versions

@AndreKurait AndreKurait merged commit e2c5be7 into opensearch-project:main Oct 18, 2024
14 checks passed
@AndreKurait AndreKurait deleted the PublishMavenVersions branch October 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants