-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cdk ecr images when docker hash changes #1080
Update cdk ecr images when docker hash changes #1080
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
=========================================
Coverage 80.63% 80.63%
Complexity 2893 2893
=========================================
Files 383 383
Lines 14342 14342
Branches 989 989
=========================================
Hits 11565 11565
Misses 2184 2184
Partials 593 593
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andre Kurait <[email protected]>
ed71888
to
f04f2a7
Compare
Signed-off-by: Andre Kurait <[email protected]>
1c377a2
to
9bc8bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comment about logging when we do the docker pull. This fixes a critical, non-obvious gap though.
- name: Mock Docker Images for CDK Tests | ||
run: | | ||
image=$(docker images --format '{{.Repository}}:{{.Tag}}' | head -n 1) | ||
echo "Using image for mocked tags: $image" | ||
docker tag $image migrations/capture_proxy:latest | ||
docker tag $image migrations/capture_proxy_es:latest | ||
docker tag $image opensearchproject/opensearch:2 | ||
docker tag $image migrations/elasticsearch_searchguard:latest | ||
docker tag $image docker.io/apache/kafka:3.7.0 | ||
docker tag $image migrations/migration_console:latest | ||
docker tag $image migrations/reindex_from_snapshot:latest | ||
docker tag $image migrations/traffic_replayer:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for removing this
Description
The ECR cdk constructs need an identifier to detect changes in docker images and republish.
This will cause stale images during updates since #1061
Issues Resolved
MIGRATIONS-2123
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Unit testing, tested in bootstrap box in Migration Assistant.
Tested in bootstrap box with cases:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.