Address code smells in DataGenerator

[peternied]

Description

Address code smells in DataGenerator

• Defined constants for reused literals
• Mark unmodified fields final
• Add a private constructor to hide the implicit public constructor

Check List

• New functionality includes testing
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (d0a0b6f) to head (b110bd8).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1076   +/-   ##
=========================================
  Coverage     80.19%   80.19%           
- Complexity     2863     2866    +3     
=========================================
  Files           383      383           
  Lines         14333    14337    +4     
  Branches        988      988           
=========================================
+ Hits          11494    11498    +4     
  Misses         2245     2245           
  Partials        594      594           

Flag	Coverage Δ
gradle-test	78.22% <100.00%> (+<0.01%)	⬆️
python-test	90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gregschohn]

UtilityClass is one annotation I'd rather us not use. It's value is marginal and it requires me to review the entire class/file, which is especially scary when looking at a diff since a reviewer won't see the whole file by default.

[peternied]

UtilityClass is one annotation I'd rather us not use. It's value is marginal and it requires me to review the entire class/file, which is especially scary when looking at a diff since a reviewer won't see the whole file by default.

Thanks for the review, I have addressed this comment.

[gregschohn]

Let's continue to not allow static imports outside of test code (this is in src, not testFixture)
Adding the classname will give names like "INTEGER" some more context and clarity

[peternied]

Thanks for the feedback, I don't agree with the style preference. I would prefer to merge this change as is.

I've created MIGRATIONS-2141 [1] to automate enforcement of style issues, lets use tooling to align our preferences.

• [1] https://opensearch.atlassian.net/browse/MIGRATIONS-2141