-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFS Workers now use EBS to store/unpack the snapshot #1041
Conversation
Signed-off-by: Chris Helma <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
=========================================
Coverage 80.57% 80.57%
Complexity 2736 2736
=========================================
Files 365 365
Lines 13611 13611
Branches 941 941
=========================================
Hits 10967 10967
Misses 2067 2067
Partials 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chris Helma <[email protected]>
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Outdated
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Outdated
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/default-values.json
Outdated
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Outdated
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Show resolved
Hide resolved
Signed-off-by: Chris Helma <[email protected]>
deployment/cdk/opensearch-service-migration/lib/network-stack.ts
Outdated
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/service-stacks/reindex-from-snapshot-stack.ts
Outdated
Show resolved
Hide resolved
size: Size.gibibytes(volumeSize), | ||
volumeType: EbsDeviceVolumeType.GP3, | ||
fileSystemType: FileSystemType.XFS, | ||
tagSpecifications: [{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EBS Console shows name which reflects the Name
tag on the volume, can we populate it with something that says RFS and the stage (different than volume name
above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see non blocking comment for tag name which can be handled in this or a follow up pr
fileSystemType: FileSystemType.XFS, | ||
tagSpecifications: [{ | ||
tags: { | ||
name: `rfs-snapshot-volume-${props.stage}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: name -> Name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, thought I had pushed that out before pinging you again. Sorry about that.
Signed-off-by: Chris Helma <[email protected]>
Description
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.