Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFS Workers now use EBS to store/unpack the snapshot #1041

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

chelma
Copy link
Member

@chelma chelma commented Oct 1, 2024

Description

  • Updated the RFS Workers to use an EBS volume to store and unpack the snapshot. Each worker gets a separate volume, which is provisioned on task launch.

Issues Resolved

Testing

  • Tested by performing a small migration in AWS and confirming separate, correctly-size volumes were used for each task
(.venv) bash-5.2# console clusters cat-indices

SOURCE CLUSTER
health status index       uuid                   pri rep docs.count docs.deleted store.size pri.store.size
green  open   bwc_index_1 QYzCFpW9RTeZ9xW3ht5eTA   1   0          1            0      3.8kb          3.8kb
green  open   fwc_index_1 Axns2r74RCiDQYt6ewLAeQ   1   0          1            0      3.8kb          3.8kb

TARGET CLUSTER
health status index                     uuid                   pri rep docs.count docs.deleted store.size pri.store.size
green  open   .migrations_working_state BUg_NWvsSE-a8kbdnPN6_Q   1   1          3            0     47.1kb          6.8kb
green  open   bwc_index_1               NR4nYu4rSiyfLNqRr3UQWw   5   1          1            0     11.5kb          5.7kb
green  open   fwc_index_1               xsBlWTtLT5-SJUUni3kBog   1   0          1            0      3.8kb          3.8kb
Screenshot 2024-10-01 at 1 54 28 PM Screenshot 2024-10-01 at 1 55 30 PM

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (5015220) to head (b983163).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1041   +/-   ##
=========================================
  Coverage     80.57%   80.57%           
  Complexity     2736     2736           
=========================================
  Files           365      365           
  Lines         13611    13611           
  Branches        941      941           
=========================================
  Hits          10967    10967           
  Misses         2067     2067           
  Partials        577      577           
Flag Coverage Δ
gradle-test 78.61% <ø> (ø)
python-test 90.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chris Helma <[email protected]>
size: Size.gibibytes(volumeSize),
volumeType: EbsDeviceVolumeType.GP3,
fileSystemType: FileSystemType.XFS,
tagSpecifications: [{
Copy link
Member

@AndreKurait AndreKurait Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EBS Console shows name which reflects the Name tag on the volume, can we populate it with something that says RFS and the stage (different than volume name above)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's case sensitive for Name
image
image

chelma added 2 commits October 1, 2024 16:26
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Copy link
Member

@AndreKurait AndreKurait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see non blocking comment for tag name which can be handled in this or a follow up pr

fileSystemType: FileSystemType.XFS,
tagSpecifications: [{
tags: {
name: `rfs-snapshot-volume-${props.stage}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: name -> Name

#1041 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, thought I had pushed that out before pinging you again. Sorry about that.

@chelma chelma merged commit 647f601 into opensearch-project:main Oct 2, 2024
14 checks passed
@chelma chelma deleted the MIGRATIONS-1750 branch October 2, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants