Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused logging utilities class #1032

Merged

Conversation

peternied
Copy link
Member

@peternied peternied commented Sep 30, 2024

Description

This class isn't used, removing for code coverage improvement and remove potential bug around configuring the root logger, java:S4792.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (7ba296e) to head (de38dcb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1032      +/-   ##
============================================
+ Coverage     80.49%   80.56%   +0.07%     
  Complexity     2736     2736              
============================================
  Files           366      365       -1     
  Lines         13623    13611      -12     
  Branches        942      941       -1     
============================================
  Hits          10966    10966              
+ Misses         2079     2067      -12     
  Partials        578      578              
Flag Coverage Δ
gradle-test 78.60% <ø> (+0.08%) ⬆️
python-test 90.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit d5f5be6 into opensearch-project:main Sep 30, 2024
14 checks passed
@peternied peternied deleted the remove-unused-logging-code branch September 30, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants