Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf version #1005

Merged
merged 2 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TrafficCapture/captureProtobufs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ plugins {

dependencies {
api project(":commonDependencyVersionConstraints")
api group: 'com.google.protobuf', name: 'protobuf-java', version: '3.22.2'
api group: 'com.google.protobuf', name: 'protobuf-java', version: '3.25.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the version from here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me test, I am also curious about this

}

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:3.22.2"
artifact = "com.google.protobuf:protoc:3.25.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try removing the version from here? I'm less sure about this one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove one of these, we really should remove the other too. I want the version specifiers to be specified together in the same file.

}
}
4 changes: 2 additions & 2 deletions commonDependencyVersionConstraints/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies {

api group: 'com.google.guava', name: 'guava', version: '32.0.1-jre'

api group: 'com.google.protobuf', name: 'protobuf-java', version: '3.22.2'
api group: 'com.google.protobuf', name: 'protobuf-java', version: '3.25.5'

api group: 'org.apache.httpcomponents.client5', name: 'httpclient5', version: '5.2.1'
api group: 'software.amazon.msk', name:'aws-msk-iam-auth', version: '2.0.3'
Expand All @@ -38,7 +38,7 @@ dependencies {

api group: 'org.apache.kafka', name:'kafka-clients', version:'3.6.0'

api group: 'com.google.protobuf', name: 'protoc', version: '3.22.2'
api group: 'com.google.protobuf', name: 'protoc', version: '3.25.5'

def jmeter = '5.6.3'
api group: 'org.apache.jmeter', name: 'ApacheJMeter_core', version: jmeter
Expand Down