Fix bug handle empty mappings when removing mapping types

- Resolves #1177 Signed-off-by: Peter Nied <[email protected]>
opensearch-project · Dec 4, 2024 · e1e03d0 · e1e03d0
1 parent d7889c3
commit e1e03d0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/...src/main/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemoval.java b/...src/main/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemoval.java
@@ -45,7 +45,7 @@ public class IndexMappingTypeRemoval implements TransformationRule<Index> {
     public CanApplyResult canApply(final Index index) {
         final var mappingNode = index.getRawJson().get(MAPPINGS_KEY);
 
-        if (mappingNode == null) {
+        if (mappingNode == null || mappingNode.size() == 0) {
             return CanApplyResult.NO;
         }
 

diff --git a/...test/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemovalTest.java b/...test/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemovalTest.java
@@ -120,6 +120,21 @@ private boolean applyTransformation(final ObjectNode indexJson) {
         return wasChanged;
     }
 
+    @Test
+    void testApplyTransformation_emptyMappingArray() {
+        // Setup
+        var originalJson = indexSettingJson("\"mappings\": [],");
+        var indexJson = originalJson.deepCopy();
+
+        // Action
+        var wasChanged = applyTransformation(indexJson);
+        assertThat(canApply(originalJson), equalTo(CanApplyResult.NO));
+
+        // Verification
+        assertThat(wasChanged, equalTo(false));
+        assertThat(indexJson.toPrettyString(), equalTo(originalJson.toPrettyString()));
+    }
+
     @Test
     void testApplyTransformation_noMappingNode() {
         // Setup