Remove memory leaks in ConditionallyReliableLoggingHttpHandlerTest

Signed-off-by: Andre Kurait <[email protected]>
opensearch-project · May 2, 2024 · 5632748 · 5632748
1 parent 751d880
commit 5632748
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...ensearch/migrations/trafficcapture/netty/ConditionallyReliableLoggingHttpHandlerTest.java b/...ensearch/migrations/trafficcapture/netty/ConditionallyReliableLoggingHttpHandlerTest.java
@@ -70,6 +70,9 @@ private static void writeMessageAndVerify(byte[] fullTrafficBytes, Consumer<Embe
                 Assertions.assertTrue(!rootContext.instrumentationBundle.getFinishedSpans().isEmpty());
                 Assertions.assertTrue(!rootContext.instrumentationBundle.getFinishedMetrics().isEmpty());
             }
+
+            channel.finishAndReleaseAll();
+            channel.close();
         }
     }
 
@@ -125,6 +128,7 @@ public void testThatSuppressedCaptureWorks() throws Exception {
                     new ConditionallyReliableLoggingHttpHandler(rootInstrumenter, "n", "c",
                             ctx -> offloader, headerCapturePredicate, x -> true));
             getWriter(false, true, SimpleRequests.HEALTH_CHECK.getBytes(StandardCharsets.UTF_8)).accept(channel);
+            channel.finishAndReleaseAll();
             channel.close();
             var requestBytes = SimpleRequests.HEALTH_CHECK.getBytes(StandardCharsets.UTF_8);