Prepare Release 2.5.1 #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudhvigodithi
requested review from
idanl21,
dbason,
swoehrl-mw,
jochenkressin,
pchmielnik and
salyh
as code owners
Signed-off-by: Prudhvi Godithi <[email protected]>
bbarani
approved these changes
Feb 2, 2024
gaiksaya
reviewed
Feb 2, 2024
gaiksaya
reviewed
Feb 2, 2024
| @@ -120,7 +120,8 @@ pipeline { | |||
| string(name: 'RELEASE_VERSION', value: "${OPERATOR_VERSION}"), | |||
| booleanParam(name: 'DOCKER_HUB_PROMOTE', value: true), | |||
| booleanParam(name: 'ECR_PROMOTE', value: true), | |||
| booleanParam(name: 'TAG_LATEST', value: true) | |||
| booleanParam(name: 'TAG_LATEST', value: true), | |||
| booleanParam(name: 'TAG_MAJOR_VERSION', value: false) | |||
There was a problem hiding this comment.
Don't we want to update the major version tag? Example: 2.5.1 -> 2
There was a problem hiding this comment.
Adding @swoehrl-mw.
Sayali mostly the operator is installed and managed via helm and helm charts have fixed versions in Chart.yml, docker run wont work here hence I dont see a need to keep TAG_MAJOR_VERSION which adds more noise.
There was a problem hiding this comment.
The docker-promotion job has default TAG_MAJOR_VERSION to true hence disabling it.
|
Please verify the image is accessible Also please update the opensearch versions we can install with this operator |
|
Hey @vipinjn24 please check the the workaround I have posted here #709 (comment), also this PR should fix it. |
gaiksaya
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepare Release 2.5.1
Issues Resolved
Part of #709 and #674
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.