Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MAINTAINERS and CONTRIBUTING guidelines for DCO #53

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Adding MAINTAINERS and CONTRIBUTING guidelines for DCO #53

merged 2 commits into from
Mar 4, 2022

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Mar 3, 2022

Maintainers file is a placeholder, and Contributing file explains the guidelines around DCO which we must enforce to avoid legal issues with code contributions.

Signed-off-by: Jonah Kowall [email protected]

MAINTAINERS.md Outdated

| Maintainer | GitHub ID | Affiliation |
| --------------- | --------- | ----------- |
| Placeholder | [placeholder](https://github.com/userid) | Company |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, we have @idanl21 , @ido-opster , and @dbason as maintainers. They can get added in separate PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add them in shortly for you

segalziv
segalziv previously approved these changes Mar 3, 2022
Copy link
Contributor

@segalziv segalziv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@segalziv
Copy link
Contributor

segalziv commented Mar 3, 2022

Thanks for the PR @jkowall.

For now, we don't enforce DCO Signed-off-by in an automated check. We should add this to the PR checks. @idanl21 .

@jkowall jkowall closed this Mar 3, 2022
@jkowall jkowall deleted the add-files branch March 3, 2022 16:35
@jkowall jkowall restored the add-files branch March 3, 2022 16:37
@jkowall jkowall reopened this Mar 3, 2022
Signed-off-by: Jonah Kowall <[email protected]>
@jkowall
Copy link
Contributor Author

jkowall commented Mar 3, 2022

You are welcome to merge now or edit, thx

@jkowall
Copy link
Contributor Author

jkowall commented Mar 3, 2022

When you want to add verification opensearch-project/OpenSearch#2317 (comment) apparently there is an app for it now.

@segalziv segalziv merged commit 7cfe2aa into opensearch-project:main Mar 4, 2022
@segalziv
Copy link
Contributor

segalziv commented Mar 4, 2022

I've installed the DCO app. Thanks for that note @jkowall

@jkowall jkowall deleted the add-files branch March 4, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants