Add serialization and deserialization of numerals larger than NumberMAX_SAFE_INTEGER (#544)
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
seanneumann,
dblock,
VachaShah,
nhtruong and
harshavamsi
as code owners
nhtruong
approved these changes
Jul 12, 2023
….MAX_SAFE_INTEGER` (opensearch-project#544) Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
backport-bigint
branch
from
471ac95 to
798b02f
Compare
dblock
reviewed
Jul 13, 2023
| * | ||
| */ | ||
|
|
||
| /* |
There was a problem hiding this comment.
This is not necessary for new code.
nhtruong
added a commit
that referenced
this pull request
Jul 18, 2023
* Add upgrading NPM to all workflows running older Node.js versions (#545) (#553) Also: * Add compatibility checks for Node.js v18 * Bump `actions/setup-node` to v3 Signed-off-by: Miki <[email protected]> * Add serialization and deserialization of numerals larger than `Number.MAX_SAFE_INTEGER` (#544) (#554) Signed-off-by: Miki <[email protected]> * Version Bump: 2.3.0 (#546) (#555) Signed-off-by: Theo Truong <[email protected]> * Make handling of long numerals an option that is disabled by default (#557) (#561) Also: * Strengthen the tests * update USER_GUIDE.md (cherry picked from commit 08069bc) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Version Bump: 2.3.1 Signed-off-by: Theo Truong <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Theo Truong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport 471ac95 from #544