Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert support for JDK8. #799

Closed
wants to merge 1 commit into from
Closed

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 3, 2024

Description

Supersedes #796 for 2.x.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator

reta commented Jan 3, 2024

@dblock do you want me to revert the change and bundle everything into #798?

@dblock
Copy link
Member Author

dblock commented Jan 3, 2024

@dblock do you want me to revert the change and bundle everything into #798?

I did the accidental merge so I feel guilty to create more work on you, let me do it.

Any reason not to merge this? I will take a variation of #798 next.

@dblock dblock marked this pull request as ready for review January 3, 2024 21:51
@reta
Copy link
Collaborator

reta commented Jan 3, 2024

I did the accidental merge so I feel guilty to create more work on you, let me do it.

Don't worry about it, it will take me just a few mins

Any reason not to merge this? I will take a variation of #798 next.

We need to bring tests from src/test/java11 back to src/test/java as well.

@dblock
Copy link
Member Author

dblock commented Jan 3, 2024

@reta Alright, thank you 🙏

@dblock dblock closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants