Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ResponseException#status (#756) #759

Merged

Conversation

rursprung
Copy link
Contributor

this allows accessing the HTTP status code of the response when an API returns a ResponseException. this was not possible through getResponse since Response itself is package-private and thus its members (even though they are marked as public) are not accessible to external consumers.

solves #749

Signed-off-by: Ralph Ursprung [email protected]
(cherry picked from commit 863518c)

backport of #756

this allows accessing the HTTP status code of the response when an API
returns a `ResponseException`. this was not possible through
`getResponse` since `Response` itself is package-private and thus its
members (even though they are marked as `public`) are not accessible to
external consumers.

solves #749

Signed-off-by: Ralph Ursprung <[email protected]>
(cherry picked from commit 863518c)
@reta reta merged commit 52b987e into opensearch-project:2.x Dec 4, 2023
44 checks passed
@rursprung rursprung deleted the backport/backport-756-to-2.x branch December 4, 2023 20:55
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants