Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing partial success results for msearch template (#709) #714

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

VachaShah
Copy link
Collaborator

  • Fixing partial success results for msearch template

  • Adding changelog

  • Spotless apply


Description

Backport #709 to 2.x

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ct#709)

* Fixing partial success results for msearch template

Signed-off-by: Vacha Shah <[email protected]>

* Adding changelog

Signed-off-by: Vacha Shah <[email protected]>

* Spotless apply

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
@reta reta merged commit a6bf1f6 into opensearch-project:2.x Nov 7, 2023
43 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.8.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8.1 2.8.1
# Navigate to the new working tree
cd .worktrees/backport-2.8.1
# Create a new branch
git switch --create backport/backport-714-to-2.8.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6bf1f68aadae01b47949cd9c3da58145c5d62f9
# Push it to GitHub
git push --set-upstream origin backport/backport-714-to-2.8.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8.1

Then, create a pull request where the base branch is 2.8.1 and the compare/head branch is backport/backport-714-to-2.8.1.

VachaShah added a commit to VachaShah/opensearch-java that referenced this pull request Nov 13, 2023
…ct#709) (opensearch-project#714)

* Fixing partial success results for msearch template

* Adding changelog

* Spotless apply

---------

Signed-off-by: Vacha Shah <[email protected]>
dblock pushed a commit that referenced this pull request Nov 14, 2023
* Fixing partial success results for msearch template

* Adding changelog

* Spotless apply

---------

Signed-off-by: Vacha Shah <[email protected]>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants