-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added size attribute to MultiTermsAggregation #627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiankopatschek Thank you for adding this! Some integ tests related to aggregations are failing. Can you take a look?
@VachaShah I did some manual testing and some research. The multi_terms feature was implemented with version 2.1.0 of opensearch. |
Yes, you can do something similar to https://github.com/opensearch-project/opensearch-java/blob/main/java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractRequestIT.java#L633. |
@VachaShah Thank you for the link. |
Looks great! Can you rebase and fix the merge conflicts in Changelog and we are good to go. |
Signed-off-by: Fabian Kopatschek <[email protected]>
Signed-off-by: Fabian Kopatschek <[email protected]>
Done :) |
* Added size attribute to MultiTermsAggregation Signed-off-by: Fabian Kopatschek <[email protected]> * Added integrationTest check if MultiTermsAggregation is supported Signed-off-by: Fabian Kopatschek <[email protected]> --------- Signed-off-by: Fabian Kopatschek <[email protected]> Signed-off-by: Vacha Shah <[email protected]>
* Added size attribute to MultiTermsAggregation * Added integrationTest check if MultiTermsAggregation is supported --------- Signed-off-by: Fabian Kopatschek <[email protected]> Signed-off-by: Vacha Shah <[email protected]> Co-authored-by: fabiankopatschek <[email protected]>
Description
Added size attribute to MultiTermsAggregation to retreive other hit sizes than the default value of the attribute.
Code for the added attribute was taken from TermsAggregation class.
This pull request replaces #614, as dblock suggested that the changes should go to the main branch.
Please backfort this code to 2.x.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.