JarHell caused by latest software.amazon.awssdk 2.20.141 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
force-pushed
the
issue-615
branch
2 times, most recently
from
3562e38 to
6ab8a31
Compare
reta
commented
Sep 6, 2023
| @@ -242,7 +242,7 @@ public void testCatPitSegments() throws Exception { | |||
|
|
|||
| assertNotNull("PitSegmentsResponse.segments() is null", PitSegmentsResponse.valueBody()); | |||
| assertTrue("PitSegmentsResponse.segments().size() == 0", | |||
| PitSegmentsResponse.valueBody().size() > 0); | |||
| PitSegmentsResponse.valueBody().isEmpty()); | |||
There was a problem hiding this comment.
Finally, test becomes logical: it was an issue fixed recently, the Cat API for PIT segments returned header row twice.
Signed-off-by: Andriy Redko <[email protected]>
|
@VachaShah @dblock could you please take a look folks? the checks are broken for this repo ... |
VachaShah
approved these changes
Sep 12, 2023
Thank you for fixing this @reta! |
|
@dblock mind please? thank you |
dblock
approved these changes
Sep 13, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-616-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7be86f3d828a7372cd908b7a3c1930b428fbed76
# Push it to GitHub
git push --set-upstream origin backport/backport-616-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
reta
added a commit
to reta/opensearch-java
that referenced
this pull request
Sep 13, 2023
…project#616) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 7be86f3)
dblock
pushed a commit
that referenced
this pull request
Sep 14, 2023
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 7be86f3)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JarHell caused by latest software.amazon.awssdk 2.20.141
Issues Resolved
Closes #615
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.