Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing user guide and adding working samples #610

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

VachaShah
Copy link
Collaborator

Description

From @dblock's work in the opensearch-py client:

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@VachaShah
Copy link
Collaborator Author

@reta @saratvemulapalli Review please?

@szczepanczykd szczepanczykd merged commit 301687d into opensearch-project:main Sep 1, 2023
@reta
Copy link
Collaborator

reta commented Sep 1, 2023

@reta @saratvemulapalli Review please?

Apologies, came late

@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Sep 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-610-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 301687d641940c891fa032b5e26f27a789906ecf
# Push it to GitHub
git push --set-upstream origin backport/backport-610-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-610-to-2.x.

VachaShah added a commit to VachaShah/opensearch-java that referenced this pull request Sep 15, 2023
…t#610)

* Reorganizing user guide and moving code snippets to guides

Signed-off-by: Vacha Shah <[email protected]>

* Adding working samples for the client

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
reta pushed a commit that referenced this pull request Sep 15, 2023
* Add k-NN guide and samples (#586)

Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>

* Reorganizing user guide and adding working samples (#610)

* Reorganizing user guide and moving code snippets to guides

Signed-off-by: Vacha Shah <[email protected]>

* Adding working samples for the client

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>

* Fixing compile errors for ApacheHttpClient5Transport

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>
@VachaShah VachaShah deleted the working-samples branch September 18, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants