Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add support for approximate k-NN queries #559

Merged
merged 2 commits into from
Jul 5, 2023
Merged

[Backport 2.x] Add support for approximate k-NN queries #559

merged 2 commits into from
Jul 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f427f27 from #548.

@github-actions
Add support for approximate k-NN queries (#548)
8feb0c8 
* Add Knn query type

Signed-off-by: Thomas Farr <[email protected]>

* Integration test

Signed-off-by: Thomas Farr <[email protected]>

* Checkstyle fix

Signed-off-by: Thomas Farr <[email protected]>

* Run unreleased test

Signed-off-by: Thomas Farr <[email protected]>

* Fixes

Signed-off-by: Thomas Farr <[email protected]>

* Assume knn plugin installed

Signed-off-by: Thomas Farr <[email protected]>

* Changelog

Signed-off-by: Thomas Farr <[email protected]>

* Add to QueryBuilders

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit f427f27)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@VachaShah
Fixing compile errors
f606a27 
Signed-off-by: Vacha Shah <[email protected]>
@VachaShah
Copy link
Collaborator

Compile errors:

public class KnnIT extends AbstractKnnIT {
> Task :java-client:compileTestJava
       ^
/home/runner/work/opensearch-java/opensearch-java/java-client/src/test/java/org/opensearch/client/opensearch/integTest/restclient/KnnIT.java:20: error: method does not override or implement a method from a supertype
    @Override
    ^
/home/runner/work/opensearch-java/opensearch-java/java-client/src/test/java/org/opensearch/client/opensearch/integTest/restclient/KnnIT.java:22: error: incompatible types: org.apache.hc.core5.http.HttpHost[] cannot be converted to org.apache.http.HttpHost[]
        return new RestClientTransport(buildClient(settings, hosts), new JacksonJsonpMapper());

@VachaShah
Copy link
Collaborator

Fixed the errors in the latest commit.

@VachaShah
Copy link
Collaborator

@reta Can I get a review for this? Thank you!

@reta reta merged commit 1eb8fc5 into 2.x Jul 5, 2023
@github-actions github-actions bot deleted the backport/backport-548-to-2.x branch July 5, 2023 19:04
@ls-urs-keller ls-urs-keller mentioned this pull request Jan 19, 2024
Closed
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@reta reta reta approved these changes

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@madhusudhankonda madhusudhankonda Awaiting requested review from madhusudhankonda madhusudhankonda is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VachaShah @reta