Manual backport: Fix suggestion classes for Term, Phrase, and Completion. (#477) #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project#477) * Fixes Completion, Phrase, and Term suggesters Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Use resource files instead of JSON strings Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Minor fixes to docs + checksytle Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Adding ES license headers for copied over files Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix example formatting Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update tests to use builders instead of JSON Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Removing un-necessary test resources Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 68e2b6f)
harshavamsi
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
VachaShah
approved these changes
Jun 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Backport of #477
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Harsha Vamsi Kalluri [email protected]
(cherry picked from commit 68e2b6f)
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.