fix: change int type to long #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Szczepanczyk <[email protected]>
szczepanczykd
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Dominik Szczepanczyk <[email protected]>
szczepanczykd
changed the title
Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: Dominik Szczepanczyk <[email protected]>
szczepanczykd
changed the title
szczepanczykd
commented
May 20, 2023
|
|
||
| @Nullable | ||
| private final String totalDataSetSize; | ||
|
|
||
| @Nullable | ||
| private final Integer totalDataSetSizeInBytes; | ||
| private final Long totalDataSetSizeInBytes; |
There was a problem hiding this comment.
I don't see this field in the response from API in version 2.7.0
Seems like it was never produced by the server, even from very first version:
https://github.com/opensearch-project/OpenSearch/blob/1.0/server/src/main/java/org/opensearch/index/store/StoreStats.java
Should I remove it or mark it as @deprecated?
There was a problem hiding this comment.
Mark it as deprecated, will remove in the next major version.
There was a problem hiding this comment.
Done in: #497 :)
dblock
approved these changes
May 21, 2023
VachaShah
approved these changes
May 22, 2023
szczepanczykd
added a commit
to szczepanczykd/opensearch-java
that referenced
this pull request
May 23, 2023
* fix: change int type to long Signed-off-by: Dominik Szczepanczyk <[email protected]> * update CHANGELOG.md Signed-off-by: Dominik Szczepanczyk <[email protected]> * fix: change totalDataSetSizeInBytes to Long too Signed-off-by: Dominik Szczepanczyk <[email protected]> * fix: skip removing opensearch-observability index in AfterTest cleanup Signed-off-by: Dominik Szczepanczyk <[email protected]> --------- Signed-off-by: Dominik Szczepanczyk <[email protected]>
dblock
pushed a commit
that referenced
this pull request
May 23, 2023
* fix: handle String error deserialization for ErrorCause object (#301) (#476) * fix: handle String error deserialization for ErrorCause object (#301) Signed-off-by: Dominik Szczepanczyk <[email protected]> * update CHANGELOG.md Signed-off-by: Dominik Szczepanczyk <[email protected]> --------- Signed-off-by: Dominik Szczepanczyk <[email protected]> * fix: change int type to long (#489) * fix: change int type to long Signed-off-by: Dominik Szczepanczyk <[email protected]> * update CHANGELOG.md Signed-off-by: Dominik Szczepanczyk <[email protected]> * fix: change totalDataSetSizeInBytes to Long too Signed-off-by: Dominik Szczepanczyk <[email protected]> * fix: skip removing opensearch-observability index in AfterTest cleanup Signed-off-by: Dominik Szczepanczyk <[email protected]> --------- Signed-off-by: Dominik Szczepanczyk <[email protected]> --------- Signed-off-by: Dominik Szczepanczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The server returns long instead of int:
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/store/StoreStats.java
Issues Resolved
#184
#490
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.