-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds point in time APIs #461
Adds point in time APIs #461
Conversation
206cd63
to
d7e6d3b
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
d7e6d3b
to
cb6d15f
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I have questions on wether the correct name is pit
or point_in_time
everywhere here?
java-client/src/main/java/org/opensearch/client/opensearch/core/SearchRequest.java
Show resolved
Hide resolved
.../main/java/org/opensearch/client/opensearch/core/point_in_time/CreatePointInTimeRequest.java
Outdated
Show resolved
Hide resolved
java-client/src/main/java/org/opensearch/client/opensearch/OpenSearchAsyncClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@VachaShah @dblock @reta this should be good to go I believe? |
Thanks for addressing comments @harshavamsi , the class names are still using [1] https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/action/search/CreatePitRequest.java |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractCatClientIT.java
Outdated
Show resolved
Hide resolved
java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractRequestIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-461-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4ceb43b00c314b6acba6d036132d1947d22b5f8d
# Push it to GitHub
git push --set-upstream origin backport/backport-461-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@harshavamsi will need a manual backport |
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit 4ceb43b)
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit 4ceb43b)
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit 4ceb43b)
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit 4ceb43b)
Just a question, when the next tag that contain this feature will be released ? |
Hi @ahmadabulaban, we are tracking the release 2.5.0 in #474. Till we release 2.5.0, you can use the snapshots we publish for the client - 2.5.0-SNAPSHOT which has the latest changes from the 2.x branch. |
Description
Adds point in time APIs that were released in OpenSearch 2.4
Issues Resolved
Closes #452
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.