Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds point in time APIs #461

Merged
merged 7 commits into from
May 3, 2023

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented Apr 24, 2023

Description

Adds point in time APIs that were released in OpenSearch 2.4

Issues Resolved

Closes #452

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@harshavamsi harshavamsi force-pushed the feature/pointintime branch from d7e6d3b to cb6d15f Compare April 24, 2023 19:23
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have questions on wether the correct name is pit or point_in_time everywhere here?

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@harshavamsi
Copy link
Contributor Author

@VachaShah @dblock @reta this should be good to go I believe?

@reta
Copy link
Collaborator

reta commented May 2, 2023

@VachaShah @dblock @reta this should be good to go I believe?

Thanks for addressing comments @harshavamsi , the class names are still using XxxPointInTimeYyy, inconsistent with core that uses shorter XxxPitYyy everywhere [1], [2], ....

[1] https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/action/search/CreatePitRequest.java
[2] https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/action/search/DeletePitAction.java

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
USER_GUIDE.md Outdated Show resolved Hide resolved
USER_GUIDE.md Outdated Show resolved Hide resolved
harshavamsi and others added 2 commits May 2, 2023 11:29
Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@dblock dblock merged commit 4ceb43b into opensearch-project:main May 3, 2023
@dblock dblock added the backport 2.x Backport to 2.x branch label May 3, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-461-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4ceb43b00c314b6acba6d036132d1947d22b5f8d
# Push it to GitHub
git push --set-upstream origin backport/backport-461-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-461-to-2.x.

@dblock
Copy link
Member

dblock commented May 3, 2023

@harshavamsi will need a manual backport

@harshavamsi harshavamsi deleted the feature/pointintime branch May 4, 2023 13:32
harshavamsi added a commit to harshavamsi/opensearch-java that referenced this pull request May 4, 2023
* Adds point in time APIs

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Add version check for Point in time tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time namespace

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time to pit everywhere

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Using AssumeTrue for tests for PIT

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 4ceb43b)
harshavamsi added a commit to harshavamsi/opensearch-java that referenced this pull request May 4, 2023
* Adds point in time APIs

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Add version check for Point in time tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time namespace

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time to pit everywhere

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Using AssumeTrue for tests for PIT

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 4ceb43b)
harshavamsi added a commit to harshavamsi/opensearch-java that referenced this pull request May 8, 2023
* Adds point in time APIs

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Add version check for Point in time tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time namespace

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time to pit everywhere

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Using AssumeTrue for tests for PIT

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 4ceb43b)
reta pushed a commit that referenced this pull request May 9, 2023
* Adds point in time APIs

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Add version check for Point in time tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time namespace

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time to pit everywhere

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Using AssumeTrue for tests for PIT

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 4ceb43b)
@ahmadabulaban
Copy link

Just a question, when the next tag that contain this feature will be released ?

@VachaShah
Copy link
Collaborator

Just a question, when the next tag that contain this feature will be released ?

Hi @ahmadabulaban, we are tracking the release 2.5.0 in #474. Till we release 2.5.0, you can use the snapshots we publish for the client - 2.5.0-SNAPSHOT which has the latest changes from the 2.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for point-in-time (PIT) APIs
5 participants