Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffered lookahead for Jackson #338

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

luneo7
Copy link
Contributor

@luneo7 luneo7 commented Jan 20, 2023

Description

Ports buffered lookahead for Jackson from elasticsearch-java elastic/elasticsearch-java#489
Improving performance hit caused by previous implementation.

Issues Resolved

Fixes #337

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator

reta commented Jan 20, 2023

@luneo7 luneo7 force-pushed the issue-337 branch 3 times, most recently from c804248 to 8710d5c Compare January 20, 2023 18:36
dblock
dblock previously approved these changes Jan 21, 2023
dblock
dblock previously approved these changes Jan 25, 2023
@luneo7
Copy link
Contributor Author

luneo7 commented Feb 24, 2023

@reta can you do a review of this PR? Thanks =]

@reta
Copy link
Collaborator

reta commented Feb 25, 2023

@reta can you do a review of this PR? Thanks =]

@luneo7 my apologies, I am on vacation at the moment, should be back at the end of the upcoming week

@dblock
Copy link
Member

dblock commented Feb 28, 2023

This LGTM. I think we need some USER_GUIDE updates for this?

reta
reta previously approved these changes Mar 3, 2023
}

public JacksonJsonpMapper() {
this(new ObjectMapper());
this(new ObjectMapper()
.configure(SerializationFeature.INDENT_OUTPUT, false)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, is this change related to the backport?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More or less (https://github.com/elastic/elasticsearch-java/blob/main/java-client/src/main/java/co/elastic/clients/json/jackson/JacksonJsonpMapper.java#L56) when back porting the Jackson buffered lookahead change, I also saw that the constructor was different, and saw that they ES improved the constructor so if we pass an existing ObjectMapper it doesn't changes its configuration. For me it is a win, since we use a singleton instance of objectmapper and we had to clone it to construct the opensearch client... since it sets JsonInclude.Include.NON_NULL and we use JsonInclude.Include.NON_ABSENT... so this change actually makes the constructor with the objectmapper param not change the objectmapper config as it was doing before.

@luneo7 luneo7 dismissed stale reviews from reta and dblock via 79e0a0a March 13, 2023 15:55
@luneo7 luneo7 requested review from reta and dblock and removed request for reta and dblock March 13, 2023 15:57
@luneo7 luneo7 requested review from dblock and reta and removed request for dblock and reta March 13, 2023 15:57
@luneo7
Copy link
Contributor Author

luneo7 commented Mar 13, 2023

@dblock @reta can you review it again? After I fixed the conflict on the CHANGELOG it lost approvals

@dblock dblock merged commit aaeb185 into opensearch-project:main Mar 16, 2023
@luneo7
Copy link
Contributor Author

luneo7 commented Mar 16, 2023

Can it be backported to 2.x? @dblock @reta

@reta reta added the backport 2.x Backport to 2.x branch label Mar 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: luneo7 <[email protected]>
(cherry picked from commit aaeb185)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Mar 16, 2023
(cherry picked from commit aaeb185)

Signed-off-by: luneo7 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
MarinaRazumovsky pushed a commit to MarinaRazumovsky/opensearch-java that referenced this pull request Mar 19, 2023
MarinaRazumovsky pushed a commit to MarinaRazumovsky/opensearch-java that referenced this pull request Mar 19, 2023
MarinaRazumovsky pushed a commit to MarinaRazumovsky/opensearch-java that referenced this pull request Mar 20, 2023
dblock added a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <[email protected]>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <[email protected]>

* Adding documentation comment

Signed-off-by: Vacha Shah <[email protected]>

* Adding tests

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <[email protected]>

* Updating the developer guide

Signed-off-by: Vacha Shah <[email protected]>

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <[email protected]>

* Remove commented code

Signed-off-by: Dan Hart <[email protected]>

* Fix format of changelog item

Signed-off-by: Dan Hart <[email protected]>

Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bumps Jackson from 2.14.1 to 2.14.2 (#357)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <[email protected]>

* Fix formatting

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <[email protected]>

* latest 2.4 version

Signed-off-by: amitai stern <[email protected]>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <[email protected]>

---------

Signed-off-by: amitai stern <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <[email protected]>

* add changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <[email protected]>

* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* fix: add a missing key propery to the RangeBucket (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* docs: add CHANGELOG entry (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

---------

Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing integration tests (#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <[email protected]>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding bulk request example in user guide (#373)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <[email protected]>

* Update Changelog

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* changes changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add 2PR approval to release workflow (#383)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding an example to use raw JSON class instead of target classes (#385)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update Gradle to 8.0.2 (#392)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add "mappings" field to IndexSettings object (#382)

Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Created untriaged issue workflow. (#364)

Signed-off-by: dblock <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add buffered lookahead for Jackson (#338)

Signed-off-by: luneo7 <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Mask env values for snapshots (#411)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix test

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>
Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: amitai stern <[email protected]>
Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: luneo7 <[email protected]>
Co-authored-by: Vacha Shah <[email protected]>
Co-authored-by: Danny Hart <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: amitai stern <[email protected]>
Co-authored-by: szczepanczykd <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Ilya Lukyanovich <[email protected]>
Co-authored-by: Lucas Rogerio Caetano Ferreira <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <[email protected]>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <[email protected]>

* Adding documentation comment

Signed-off-by: Vacha Shah <[email protected]>

* Adding tests

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <[email protected]>

* Updating the developer guide

Signed-off-by: Vacha Shah <[email protected]>

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <[email protected]>

* Remove commented code

Signed-off-by: Dan Hart <[email protected]>

* Fix format of changelog item

Signed-off-by: Dan Hart <[email protected]>

Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bumps Jackson from 2.14.1 to 2.14.2 (#357)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <[email protected]>

* Fix formatting

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <[email protected]>

* latest 2.4 version

Signed-off-by: amitai stern <[email protected]>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <[email protected]>

---------

Signed-off-by: amitai stern <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <[email protected]>

* add changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <[email protected]>

* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* fix: add a missing key propery to the RangeBucket (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* docs: add CHANGELOG entry (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

---------

Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing integration tests (#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <[email protected]>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding bulk request example in user guide (#373)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <[email protected]>

* Update Changelog

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* changes changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add 2PR approval to release workflow (#383)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding an example to use raw JSON class instead of target classes (#385)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update Gradle to 8.0.2 (#392)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add "mappings" field to IndexSettings object (#382)

Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Created untriaged issue workflow. (#364)

Signed-off-by: dblock <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add buffered lookahead for Jackson (#338)

Signed-off-by: luneo7 <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Mask env values for snapshots (#411)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix test

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>
Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: amitai stern <[email protected]>
Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: luneo7 <[email protected]>
Co-authored-by: Vacha Shah <[email protected]>
Co-authored-by: Danny Hart <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: amitai stern <[email protected]>
Co-authored-by: szczepanczykd <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Ilya Lukyanovich <[email protected]>
Co-authored-by: Lucas Rogerio Caetano Ferreira <[email protected]>
(cherry picked from commit 938170a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <[email protected]>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <[email protected]>

* Adding documentation comment

Signed-off-by: Vacha Shah <[email protected]>

* Adding tests

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <[email protected]>

* Updating the developer guide

Signed-off-by: Vacha Shah <[email protected]>

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <[email protected]>

* Remove commented code

Signed-off-by: Dan Hart <[email protected]>

* Fix format of changelog item

Signed-off-by: Dan Hart <[email protected]>

Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bumps Jackson from 2.14.1 to 2.14.2 (#357)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <[email protected]>

* Fix formatting

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <[email protected]>

* latest 2.4 version

Signed-off-by: amitai stern <[email protected]>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <[email protected]>

---------

Signed-off-by: amitai stern <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <[email protected]>

* add changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <[email protected]>

* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* fix: add a missing key propery to the RangeBucket (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* docs: add CHANGELOG entry (#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

---------

Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing integration tests (#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <[email protected]>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding bulk request example in user guide (#373)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <[email protected]>

* Update Changelog

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* changes changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add 2PR approval to release workflow (#383)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding an example to use raw JSON class instead of target classes (#385)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update Gradle to 8.0.2 (#392)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add "mappings" field to IndexSettings object (#382)

Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Created untriaged issue workflow. (#364)

Signed-off-by: dblock <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add buffered lookahead for Jackson (#338)

Signed-off-by: luneo7 <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Mask env values for snapshots (#411)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix test

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>
Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: amitai stern <[email protected]>
Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: luneo7 <[email protected]>
Co-authored-by: Vacha Shah <[email protected]>
Co-authored-by: Danny Hart <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: amitai stern <[email protected]>
Co-authored-by: szczepanczykd <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Ilya Lukyanovich <[email protected]>
Co-authored-by: Lucas Rogerio Caetano Ferreira <[email protected]>
(cherry picked from commit 938170a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>
dblock added a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests



* Adding CHANGELOG entry



* Adding documentation comment



* Adding tests



* Addressing comments



* Addressing comments



* Removing refresh policy for integ tests for Sigv4



* Updating the developer guide






* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida



* Remove commented code



* Fix format of changelog item






* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.






* Bumps Jackson from 2.14.1 to 2.14.2 (#357)




* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options



* Fix formatting



---------




* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5



* latest 2.4 version



* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0



---------




* add option to set columns into cat indices request



* add changelog



* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests



* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)



* fix: add a missing key propery to the RangeBucket (#369)



* docs: add CHANGELOG entry (#369)



---------




* Fixing integration tests (#375)

* Fixing integration tests



* Updating the test with a non-exact check



---------




* Adding bulk request example in user guide (#373)




* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled



* Update Changelog



---------





* changes changelog



* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...



* Update changelog



---------






* Add 2PR approval to release workflow (#383)




* Adding an example to use raw JSON class instead of target classes (#385)




* Update Gradle to 8.0.2 (#392)




* Add "mappings" field to IndexSettings object (#382)




* Created untriaged issue workflow. (#364)




* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...



* Update changelog



---------






* Add buffered lookahead for Jackson (#338)




* Mask env values for snapshots (#411)




* option to set headers and sort into cat requests



* fix test



* fix changelog



* add cat examples into USER_GUID



---------

























(cherry picked from commit 938170a)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>
Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: amitai stern <[email protected]>
Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: luneo7 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vacha Shah <[email protected]>
Co-authored-by: Danny Hart <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: amitai stern <[email protected]>
Co-authored-by: szczepanczykd <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Ilya Lukyanovich <[email protected]>
Co-authored-by: Lucas Rogerio Caetano Ferreira <[email protected]>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port buffered lookahead for Jackson from elasticsearch-java
3 participants