Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds release workflows to onboard to new release process #321

Merged
merged 6 commits into from
Jan 13, 2023

Conversation

gaiksaya
Copy link
Member

Description

Adds release workflows to onboard to new release process. Need to add webhook and bot user to this repo. Will take care of it by the time this is reviewed.

Issues Resolved

resolves opensearch-project/opensearch-build#3086

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
VachaShah
VachaShah previously approved these changes Jan 12, 2023
Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gaiksaya!

dblock
dblock previously approved these changes Jan 12, 2023
CHANGELOG.md Outdated
@@ -6,6 +6,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Github workflow for changelog verification ([#239](https://github.com/opensearch-project/opensearch-java/pull/239))
- Github workflow for dependabot PRs ([#247](https://github.com/opensearch-project/opensearch-java/pull/247))
- Add javadoc link for the client ([#255](https://github.com/opensearch-project/opensearch-java/pull/255))
- Add new release workflows ([#321](https://github.com/opensearch-project/opensearch-java/pull/321))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: let's change "new" to "1-click"? It explains what this does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Looks like need an approval again!
cc: @VachaShah

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya dismissed stale reviews from dblock and VachaShah via 6726219 January 12, 2023 23:13
@dblock dblock merged commit c171531 into opensearch-project:main Jan 13, 2023
@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Jan 24, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-321-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c171531bb51625023cef8da6e0b5fb270e7fd626
# Push it to GitHub
git push --set-upstream origin backport/backport-321-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-321-to-2.x.

gaiksaya added a commit that referenced this pull request Jan 24, 2023
* Add release workflows

Signed-off-by: Sayali Gaikawad <[email protected]>

(cherry picked from commit c171531)
VachaShah pushed a commit that referenced this pull request Jan 24, 2023
* Add release workflows

Signed-off-by: Sayali Gaikawad <[email protected]>

(cherry picked from commit c171531)
@gaiksaya gaiksaya deleted the refactor-release branch January 24, 2023 22:25
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard opensearch-java to new release process
3 participants