Fix: Make ChildrenAggregate as a SingleBucketAggregate #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siva <[email protected]>
sivaGH3
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Siva <[email protected]>
wbeckler
approved these changes
Dec 28, 2022
wbeckler
previously approved these changes
Dec 28, 2022
|
It might be helpful to add a test case for this. |
Certainly +1, we need a test case to show off the issue (and the fix in action) |
Signed-off-by: Siva <[email protected]>
|
added ChildAggregation test case |
|
@sivaGH3 please fix checkstyle violations, thank you |
Signed-off-by: Siva <[email protected]>
reta
approved these changes
Dec 29, 2022
|
@wbeckler please review this PR again, thanks |
|
I'll defer to one of the maintainers to do the second review. |
|
@Bukhtawar @dblock @madhusudhankonda @saratvemulapalli @VachaShah , can I get one more review, thanks |
sivaGH3
added a commit
to sivaGH3/opensearch-java
that referenced
this pull request
Jan 3, 2023
…te (opensearch-project#306) Signed-off-by: Siva <[email protected]>
|
@sivaGH3 could you please backport to |
dblock
pushed a commit
that referenced
this pull request
Jan 4, 2023
…te (#306) (#310) Signed-off-by: Siva <[email protected]> Signed-off-by: Siva <[email protected]>
sivaGH3
added a commit
to sivaGH3/opensearch-java
that referenced
this pull request
Jan 5, 2023
…te (opensearch-project#306) Signed-off-by: Siva <[email protected]>
dblock
pushed a commit
that referenced
this pull request
Jan 6, 2023
…te (#306) (#313) Signed-off-by: Siva <[email protected]> Signed-off-by: Siva <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Siva [email protected]
Description
Make ChildrenAggregate as a SingleBucketAggregate.
Delete
ChildrenAggregateBucket.java.Tested the change.
Issues Resolved
Closes #305
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.