Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implement SortOptionsVariant in FieldSort (#1323) #1329

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Backport 2.x] Implement SortOptionsVariant in FieldSort (#1323) #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Fixed
- Fixed `IcuCollationDecomposition`'s variants to align with those supported by OpenSearch ([#]())
- Fixed don't invoke the mapper's serialize method for the RangeQuery JsonData raw value [#1309](https://github.com/opensearch-project/opensearch-java/pull/1309)
- Fixed an issue where `FieldSort` was not implementing `SortOptionsVariant` ([#1323](https://github.com/opensearch-project/opensearch-java/pull/1323))

### Security

Expand Down
10 changes: 9 additions & 1 deletion java-client/src/main/java/org/opensearch/client/opensearch/_types/FieldSort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
// typedef: _types.FieldSort

@JsonpDeserializable
public class FieldSort implements PlainJsonSerializable {
public class FieldSort implements SortOptionsVariant, PlainJsonSerializable {
// Single key dictionary
private final String field;

Expand Down Expand Up @@ -94,6 +94,14 @@ public static FieldSort of(Function<Builder, ObjectBuilder<FieldSort>> fn) {
return fn.apply(new Builder()).build();
}

/**
* SortOptions variant kind.
*/
@Override
public SortOptions.Kind _sortOptionsKind() {
return SortOptions.Kind.Field;
}

/**
* Required - The target field
*/
Expand Down
Loading