Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Missing options in Multisearch request item body #506

Closed
Mstrutov opened this issue May 31, 2023 · 1 comment · Fixed by #516
Closed

[BUG] Missing options in Multisearch request item body #506

Mstrutov opened this issue May 31, 2023 · 1 comment · Fixed by #516
Labels
bug Something isn't working

Comments

@Mstrutov
Copy link
Contributor

Mstrutov commented May 31, 2023 •
edited
Loading

What is the bug?

Cannot provide the following properties using JAVA API in MultisearchBody request:

  • minScore
  • postFilter
  • searchAfter
  • sort
  • trackScores

The MultisearchBody.Builder doesn't have such fields. The analagous class for Elastic has, e.g. minScore.

How can one reproduce the bug?

Try to create RequestItem with MultisearchHeader and MultisearchBody containing one of the mentioned fields.

What is the expected behavior?

API is extended to support these fields.

What is your host/environment?

Windows 10, OpenJDK 11, opensearch-java:2.4.0

Do you have any additional context?

Used a patched fork with field support to solve the problem locally. Going to PR after getting the tests done.
@Mstrutov Mstrutov added bug Something isn't working untriaged labels May 31, 2023
@wbeckler
Copy link

Thank you for this!!!

Mstrutov pushed a commit to Mstrutov/opensearch-java that referenced this issue Jun 5, 2023
fix: add several missing fields in MultisearchBody.Builder (opensearc…
7ecfcb9 
…h-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>
Mstrutov pushed a commit to Mstrutov/opensearch-java that referenced this issue Jun 5, 2023
fix: add several missing fields in MultisearchBody.Builder (opensearc…
a28841c 
…h-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>
@Mstrutov Mstrutov mentioned this issue Jun 5, 2023
Merged
Mstrutov added a commit to Mstrutov/opensearch-java that referenced this issue Jun 5, 2023
@Mstrutov
fix: add several missing fields in MultisearchBody.Builder (opensearc…
23bfd9b 
…h-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>
Mstrutov added a commit to Mstrutov/opensearch-java that referenced this issue Jun 5, 2023
@Mstrutov
fix: add several missing fields in MultisearchBody.Builder (opensearc…
f28080e 
…h-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>
Mstrutov added a commit to Mstrutov/opensearch-java that referenced this issue Jun 5, 2023
@Mstrutov
fix: add several missing fields in MultisearchBody.Builder (opensearc…
0f5bae8 
…h-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>
VachaShah pushed a commit that referenced this issue Jun 5, 2023
@Mstrutov
fix: add several missing fields in MultisearchBody.Builder (#506) (#516)
14303de 
* fix: add several missing fields in MultisearchBody.Builder (#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>

* update CHANGELOG.md

Signed-off-by: Maksim Strutovskii <[email protected]>

---------

Signed-off-by: Maksim Strutovskii <[email protected]>
reta pushed a commit to reta/opensearch-java that referenced this issue Jun 6, 2023
@Mstrutov @reta
fix: add several missing fields in MultisearchBody.Builder (opensearc…
16122b0 
…h-project#506) (opensearch-project#516)

* fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>

* update CHANGELOG.md

Signed-off-by: Maksim Strutovskii <[email protected]>

---------

Signed-off-by: Maksim Strutovskii <[email protected]>
reta pushed a commit to reta/opensearch-java that referenced this issue Jun 6, 2023
@Mstrutov @reta
fix: add several missing fields in MultisearchBody.Builder (opensearc…
19dc83f 
…h-project#506) (opensearch-project#516)

* fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>

* update CHANGELOG.md

Signed-off-by: Maksim Strutovskii <[email protected]>

---------

Signed-off-by: Maksim Strutovskii <[email protected]>
reta pushed a commit to reta/opensearch-java that referenced this issue Jun 6, 2023
@Mstrutov @reta
fix: add several missing fields in MultisearchBody.Builder (opensearc…
49a8948 
…h-project#506) (opensearch-project#516)

* fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody

Signed-off-by: Maksim Strutovskii <[email protected]>

* update CHANGELOG.md

Signed-off-by: Maksim Strutovskii <[email protected]>

---------

Signed-off-by: Maksim Strutovskii <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit that referenced this issue Jun 6, 2023
@reta @Mstrutov
fix: add several missing fields in MultisearchBody.Builder (#506) (#516…
d376527 
…) (#519)

* fix: add several missing fields in MultisearchBody.Builder (#506)

- add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody



* update CHANGELOG.md



---------

Signed-off-by: Maksim Strutovskii <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: Mstrutov <[email protected]>
@ls-urs-keller ls-urs-keller mentioned this issue Jan 19, 2024
Closed
@BrendonFaleiro BrendonFaleiro mentioned this issue Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add several missing fields in MultisearchBody.Builder (#506) Mstrutov/opensearch-java
2 participants
@wbeckler @Mstrutov