Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Auto slicing is not supported for DeleteByQuery, Reindex, and UpdateByQuery #283

Closed
fs-chris opened this issue Nov 28, 2022 · 1 comment · Fixed by #538
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@fs-chris
Copy link
Contributor

What is the bug?

The API does not allow defining auto-slicing for DeleteByQueryRequest, ReindexRequest, and UpdateByQueryRequest.
JavaDoc suggests using 'auto' but only Long value is accepted.

		/**
		 * The number of slices this task should be divided into. Defaults to 1, meaning
		 * the task isn't sliced into subtasks. Can be set to <code>auto</code>.
		 * <p>
		 * API name: {@code slices}
		 */
		public final Builder slices(@Nullable Long value) {
			this.slices = value;
			return this;
		}

How can one reproduce the bug?

n/a

What is the expected behavior?

Add support for configuring automatic slicing.

What is your host/environment?

Linux/Windows, Java 17
OpenSearch server 2.4.0
OpenSearch client 2.1.0

Do you have any screenshots?

n/a

Do you have any additional context?

@fs-chris fs-chris added bug Something isn't working untriaged labels Nov 28, 2022
@wbeckler
Copy link

This is a good catch. Feel free to submit a PR.

@VachaShah VachaShah added the good first issue Good for newcomers label Mar 1, 2023
@urinud urinud mentioned this issue Jun 22, 2023
urinud added a commit to urinud/opensearch-java that referenced this issue Jun 28, 2023
Signed-off-by: Uriel Dan Nudelman <[email protected]>
urinud added a commit to urinud/opensearch-java that referenced this issue Jun 28, 2023
Signed-off-by: Uriel Dan Nudelman <[email protected]>
urinud added a commit to urinud/opensearch-java that referenced this issue Jun 28, 2023
Signed-off-by: Uriel Dan Nudelman <[email protected]>
@reta reta closed this as completed in #538 Jul 3, 2023
reta pushed a commit that referenced this issue Jul 3, 2023
Signed-off-by: Uriel Dan Nudelman <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jul 3, 2023
Signed-off-by: Uriel Dan Nudelman <[email protected]>
(cherry picked from commit 8525530)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this issue Jul 3, 2023
(cherry picked from commit 8525530)

Signed-off-by: Uriel Dan Nudelman <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BrendonFaleiro BrendonFaleiro mentioned this issue Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants