-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Bulk UpdateOperation misses upsert options #282
Comments
This makes sense. Are you up for a PR for this? |
I'm sorry, but because of the number and severity of bugs in the current version of this client I had to switch to the HLRC which appears to be more mature. |
Hi guys, this capability is basic and important. |
Nothing is scheduled for this issue but it sounds like a blocker to deprecating the hlrc. @fs-chris what other issues were driving you away from OpenSearch-java? |
Besides this one, there is another show-stopper for me: support of sub-aggregations #197 Other, less significant yet annoying issues are
To be fair, the Elasticsearch version of this client also has lots of problems which mainly originate in a wrong or incomplete data model, which often leads to missing-required-property exception that prevents getting responses for certain requests. With OpenSearch-client, I didn't reach the point where I would trap into similar issues, since they occur at execution time only. |
I appreciate all work done to improve this client. |
Hi guys, For example we would like to create an opensearch Script object, and use it like below:
our team would greatly appreciate your estimation regarding supporting this. |
@assafcoh Try contributing this feature? What help do you need? |
unfortunately we currently don't have capacity to contribute. |
@dblock I think I could help here and look into the issue |
Any thoughts on which release and timeline this is targeted for? |
Next release. @wbeckler When do you want to release next? |
I think any maintainer can trigger a release and we have not decided on a set schedule for releases. @paniavula what are the implications for you in terms of the timing of the next release? |
This is a blocker for us and cannot switch to using this library as it is a core need in our current version. A more frequent monthly release schedule may also help to boost some confidence. |
@VachaShah I think nothing is stopping us from making the release, wdyt? (number of important fixes are in) |
Yeah nothing is blocking, we can do the next release. I will wait for some fixes that are already in PRs to go in so we can release them as well. |
Tracking the release in #380 :) |
Signed-off-by: Uriel Dan Nudelman <[email protected]>
Signed-off-by: Uriel Dan Nudelman <[email protected]>
# This is the 1st commit message: Fixes opensearch-project#282 Signed-off-by: Uriel Dan Nudelman <[email protected]> # This is the commit message opensearch-project#2: Fixes opensearch-project#282 Signed-off-by: Uriel Dan Nudelman <[email protected]> # This is the commit message opensearch-project#3: Add UnitTests Signed-off-by: Uriel Dan Nudelman <[email protected]>
Signed-off-by: Uriel Dan Nudelman <[email protected]>
What is the bug?
The
UpdateOperation
only supports setting adocument
.There are no options for defining upserts like
script, (scripted-)upsert, docAsUpsert
etc. as in the commonorg.opensearch.client.opensearch.core.UpdateRequest
In Elasticsearch these settings are done for bulks via
UpdateAction
which can be set into theUpdateOperation
.How can one reproduce the bug?
n/a
What is the expected behavior?
Bulk
UpdateOperation
s should support all update/upsert options as inorg.opensearch.client.opensearch.core.UpdateRequest
What is your host/environment?
Windows and Linux, Java 17
OpenSearch server 2.4.0
OpenSearch client 2.1.0
Do you have any screenshots?
n/a
Do you have any additional context?
The text was updated successfully, but these errors were encountered: