Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Suggest field to the SearchResp struct #602

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Add the Suggest field to the SearchResp struct #602

merged 4 commits into from
Aug 20, 2024

Conversation

zr-bennettm
Copy link
Contributor

Description

Adding the Explanation field to the

Issues Resolved

Closes issue #601

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bennett Mountain <[email protected]>
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (06a6dc8) to head (679eaa7).
Report is 58 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #602       +/-   ##
===========================================
+ Coverage   57.29%   67.99%   +10.70%     
===========================================
  Files         315      376       +61     
  Lines        9823     8862      -961     
===========================================
+ Hits         5628     6026      +398     
+ Misses       2902     1555     -1347     
+ Partials     1293     1281       -12     
Flag Coverage Δ
integration 60.35% <ø> (+9.51%) ⬆️
unit 15.37% <ø> (+2.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
opensearchapi/api_search.go 100.00% <ø> (ø)

... and 272 files with indirect coverage changes

@dblock
Copy link
Member

dblock commented Aug 20, 2024

Thanks for this! I fixed integration tests in #600, FYI.

We also have #284 open. Would you mind please checking whether https://github.com/opensearch-project/opensearch-api-specification has this field and a test for it in https://github.com/opensearch-project/opensearch-api-specification/tree/main/tests, and if not maybe adding it? We want to make sure we don't introduce regressions when we replace this code with generated one (can use help on that too ;)).

dblock
dblock previously approved these changes Aug 20, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See nit below.

Please rebase after #600? Thanks.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: Bennett Mountain <[email protected]>
@dblock dblock merged commit bf9998c into opensearch-project:main Aug 20, 2024
54 of 55 checks passed
@zr-bennettm
Copy link
Contributor Author

thanks for the quick approval @dblock ! Could I expect to see this be part of the next release (4.2)?

@dblock
Copy link
Member

dblock commented Aug 20, 2024

For sure. If you really, really need a release soon(er) open a "Release v. Next" issue and we'll take care of it.

(And if you do spend a little bit of time on my ask above for the API spec, it might happen faster ;)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants