-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Suggest field to the SearchResp struct #602
Conversation
Signed-off-by: Bennett Mountain <[email protected]>
Signed-off-by: Bennett Mountain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
===========================================
+ Coverage 57.29% 67.99% +10.70%
===========================================
Files 315 376 +61
Lines 9823 8862 -961
===========================================
+ Hits 5628 6026 +398
+ Misses 2902 1555 -1347
+ Partials 1293 1281 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks for this! I fixed integration tests in #600, FYI. We also have #284 open. Would you mind please checking whether https://github.com/opensearch-project/opensearch-api-specification has this field and a test for it in https://github.com/opensearch-project/opensearch-api-specification/tree/main/tests, and if not maybe adding it? We want to make sure we don't introduce regressions when we replace this code with generated one (can use help on that too ;)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See nit below.
Please rebase after #600? Thanks.
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Bennett Mountain <[email protected]>
thanks for the quick approval @dblock ! Could I expect to see this be part of the next release (4.2)? |
For sure. If you really, really need a release soon(er) open a "Release v. Next" issue and we'll take care of it. (And if you do spend a little bit of time on my ask above for the API spec, it might happen faster ;)). |
Description
Adding the
Explanation
field to theIssues Resolved
Closes issue #601
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.