-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes opensearch-project/opensearch-go#522 #523
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 57.29% 66.20% +8.91%
==========================================
Files 315 364 +49
Lines 9823 8585 -1238
==========================================
+ Hits 5628 5684 +56
+ Misses 2902 1589 -1313
- Partials 1293 1312 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add a line to CHANGELOG please and we're good to go. |
Also see #522 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Would be great to have a section in the user guide on error handling.
@martingrzzler You have to sign all your commits with DCO please ( |
Signed-off-by: Martin Gressler <[email protected]>
Signed-off-by: Martin Gressler <[email protected]>
Signed-off-by: Martin Gressler <[email protected]>
Description
Add test for 429 example response. Handle the error with an added sentinel.