-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move error structs from opensearchapi to opensearch to be reused by plugins #512
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
===========================================
+ Coverage 57.29% 77.70% +20.41%
===========================================
Files 315 13 -302
Lines 9823 1673 -8150
===========================================
- Hits 5628 1300 -4328
+ Misses 2902 296 -2606
+ Partials 1293 77 -1216
Flags with carried forward coverage won't be shown. Click here to find out more.
|
720870c
to
a85e25b
Compare
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
… ParseError Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
…stom error Signed-off-by: Jakob Hahn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a publicly-facing backwards-incompatible breaking change? Unless you want to inherit these error types in old names and mark those deprecated, let's bump the version to 4 as part of it?
Signed-off-by: Jakob Hahn <[email protected]>
I adjusted the upgrading.md to version 4.0.0. Do you want the release done in this PR or after all my other PRs are merged? |
After. Usually the version number should be set on working code as early as possible so that nobody confuses it with released code of the previous version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this.
Would it make sense to make some of things like ParseError
or UnmarshalJSON
private only?
Description
This is a braking change as the error types are moved to another project and also get renamed.
Needed as preparation for plugin integrations.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.