-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search request missing a slash when no indices are given #471
Conversation
Draft as I am waiting for a reply on the issue to maybe adjust the integration tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 57.29% 57.29%
=======================================
Files 315 315
Lines 9823 9823
=======================================
Hits 5628 5628
Misses 2902 2902
Partials 1293 1293
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Definitely needs tests! Thanks for fixing this. |
@Jakob3xD Want to finish this? |
Well, I can mark it as ready but I have no idea for testing this in a useful way for all endpoints. |
I would at a minimum add a test for this specific endpoint (this bug). But something that iterates over all APIs would be better. |
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Description
Add missing
/
for search requests when not searching specific indices.Issues Resolved
Closes #470
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.