feat: use ipv4 by default to fix CI flow #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
xluo-aws,
Hailong-am,
ruanyl,
wanglam and
raintygao
as code owners
SuZhou-Joe
force-pushed
the
fix/ipv6-by-node-upgrade
branch
from
f013e5a to
4e8ac2f
Compare
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Hailong-am
reviewed
Nov 24, 2023
Signed-off-by: SuZhou-Joe <[email protected]>
|
@SuZhou-Joe Do we need to backport 2.x branch? |
We should I suppose. |
|
Follow issue for flaky test: #961 |
Hailong-am
reviewed
Nov 24, 2023
wanglam
approved these changes
Nov 24, 2023
SuZhou-Joe
force-pushed
the
fix/ipv6-by-node-upgrade
branch
3 times, most recently
from
6b20efc to
f487a8e
Compare
This reverts commit b7caeb7. Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
fix/ipv6-by-node-upgrade
branch
from
679285b to
4b866dc
Compare
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
fix/ipv6-by-node-upgrade
branch
from
4b866dc to
cf5c6b9
Compare
|
In order to make vanilla tests run, we had to downgrade chrome version to v115, or the cypress will hang because of memory limit. I found that we use a customized image in OSD to run cypress test. @kavilla , do you have any context here why we use a customized image instead of the default github runner-image? |
Signed-off-by: SuZhou-Joe <[email protected]>
yuye-aws
approved these changes
Nov 29, 2023
Hailong-am
approved these changes
Nov 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
* feat: use ipv4 by default to fix CI flow Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove duplicate NODE_OPTIONS Signed-off-by: SuZhou-Joe <[email protected]> * fix: hang test cases Signed-off-by: SuZhou-Joe <[email protected]> * fix: typo Signed-off-by: SuZhou-Joe <[email protected]> * Revert "fix: hang test cases" This reverts commit b7caeb7. Signed-off-by: SuZhou-Joe <[email protected]> * fix: enable dev-shm to address hang test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add wait to fix hang Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert image version back to 2.308.0-1 Signed-off-by: SuZhou-Joe <[email protected]> * feat: downgrade chrome version to v115 Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert chromuim downgrade logic Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit c875187)
SuZhou-Joe
added a commit
that referenced
this pull request
Nov 29, 2023
* feat: use ipv4 by default to fix CI flow Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove duplicate NODE_OPTIONS Signed-off-by: SuZhou-Joe <[email protected]> * fix: hang test cases Signed-off-by: SuZhou-Joe <[email protected]> * fix: typo Signed-off-by: SuZhou-Joe <[email protected]> * Revert "fix: hang test cases" This reverts commit b7caeb7. Signed-off-by: SuZhou-Joe <[email protected]> * fix: enable dev-shm to address hang test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add wait to fix hang Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert image version back to 2.308.0-1 Signed-off-by: SuZhou-Joe <[email protected]> * feat: downgrade chrome version to v115 Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert chromuim downgrade logic Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit c875187) Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
to SuZhou-Joe/opensearch-dashboards-functional-test
that referenced
this pull request
Dec 18, 2023
* feat: use ipv4 by default to fix CI flow Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove duplicate NODE_OPTIONS Signed-off-by: SuZhou-Joe <[email protected]> * fix: hang test cases Signed-off-by: SuZhou-Joe <[email protected]> * fix: typo Signed-off-by: SuZhou-Joe <[email protected]> * Revert "fix: hang test cases" This reverts commit b7caeb7. Signed-off-by: SuZhou-Joe <[email protected]> * fix: enable dev-shm to address hang test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add wait to fix hang Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert image version back to 2.308.0-1 Signed-off-by: SuZhou-Joe <[email protected]> * feat: downgrade chrome version to v115 Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert chromuim downgrade logic Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#902
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.