[Alerting 2.10] Override element covered check for name input in Composite monitor creation #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
amsiglan
changed the title
kavilla
reviewed
Sep 15, 2023
| .type('{selectall}') | ||
| .type('{backspace}') | ||
| .type('Composite trigger'); | ||
| .type('{selectall}', { force: true }) |
There was a problem hiding this comment.
in the past I saw potentially cypress's focus are taken over, so would the typing delay here help as well (like on line 86)
There was a problem hiding this comment.
There we have delay because it is a combo-box and we wait for the dropdown to show up, where as here it is an input box, so we should not need a delay
There was a problem hiding this comment.
Though I will take a second pass later to ensure we have focus calls on all the input elements to make the tests more robust
kavilla
approved these changes
Sep 15, 2023
amsiglan
added a commit
to amsiglan/opensearch-dashboards-functional-test
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
1 task
kavilla
pushed a commit
that referenced
this pull request
Oct 6, 2023
* forcing name typing (#865) Signed-off-by: Amardeepsingh Siglani <[email protected]> * [Alerting] use input element for typing (#872) When selecting delegate monitors for composite monitor creation, we are typing in the combo box div element which is throwing invalid typing element error. This PR fixes that by selecting the child input element instead. This change is already part of #866 for 2.x Issues Resolved: opensearch-project/alerting-dashboards-plugin#728 Signed-off-by: Amardeepsingh Siglani <[email protected]> * wait before checking update status Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are seeing flaky behavior when creating composite monitor. The name input element is sometimes not in view which prevents cypress from typing the name. Since this behavior won't happen when a user is creating the monitor it is safe to force the typing in the name element and the monitor selector elements.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.